Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move core to common-core #777

Merged
merged 4 commits into from
Oct 26, 2022
Merged

refactor: move core to common-core #777

merged 4 commits into from
Oct 26, 2022

Conversation

ErnoW
Copy link
Member

@ErnoW ErnoW commented Oct 25, 2022


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Move core to common-core

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 6757267

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
demo-parse-server-migration Minor
@moralisweb3/api-utils Minor
@moralisweb3/auth Minor
@moralisweb3/client-firebase-auth-utils Minor
@moralisweb3/client-firebase-evm-auth Minor
@moralisweb3/client-firebase-sol-auth Minor
@moralisweb3/common-core Minor
@moralisweb3/common-evm-utils Minor
@moralisweb3/common-sol-utils Minor
@moralisweb3/common-streams-utils Minor
@moralisweb3/evm-api Minor
moralis Minor
@moralisweb3/sol-api Minor
@moralisweb3/streams Minor
@moralisweb3/test-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ErnoW ErnoW requested review from b4rtaz, sogunshola and Y0moo October 25, 2022 15:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

Test coverage

Title Lines Statements Branches Functions
api-utils Coverage: 60%
60.45% (295/488) 44.62% (54/121) 64.48% (69/107)
auth Coverage: 100%
100% (143/143) 90.9% (20/22) 100% (42/42)
evm-api Coverage: 82%
81.46% (466/572) 16.56% (54/326) 64.3% (191/297)
common-evm-utils Coverage: 62%
63.05% (669/1061) 35.01% (104/297) 30.43% (112/368)
sol-api Coverage: 100%
100% (20/20) 66.66% (4/6) 100% (6/6)
common-sol-utils Coverage: 67%
67.03% (120/179) 63.15% (12/19) 46.26% (31/67)
common-streams-utils Coverage: 95%
95.6% (674/705) 97.93% (190/194) 100% (244/244)
streams Coverage: 82%
82.72% (388/469) 64% (64/100) 73.6% (92/125)

Copy link
Collaborator

@b4rtaz b4rtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine! But I think we could also rename MoralisCore -> Core and MoralisCoreProvider -> CoreProvider as I did for utils packages. Currently names of module classes are too long, so I think we could remove the Moralis prefix.

@ErnoW ErnoW merged commit 241a7a1 into beta Oct 26, 2022
@ErnoW ErnoW deleted the move-core-to-common branch October 26, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants