Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename networkType param and set default #714

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Conversation

ErnoW
Copy link
Member

@ErnoW ErnoW commented Sep 29, 2022


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

  • Rename network to networkType
  • Set default value to evm
  • Add missing tests for Auth

@ErnoW ErnoW requested a review from b4rtaz September 29, 2022 16:44
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022

🦋 Changeset detected

Latest commit: cb258e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@moralisweb3/auth Patch
@moralisweb3/evm-utils Patch
@moralisweb3/streams Patch
moralis Patch
@moralisweb3/core Patch
@moralisweb3/api-utils Patch
@moralisweb3/sol-utils Patch
@moralisweb3/evm-api Patch
@moralisweb3/sol-api Patch
@moralisweb3/client-firebase-auth-utils Patch
@moralisweb3/client-firebase-evm-auth Patch
@moralisweb3/client-firebase-sol-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ErnoW ErnoW marked this pull request as ready for review September 29, 2022 16:44
b4rtaz
b4rtaz previously approved these changes Sep 30, 2022
@b4rtaz
Copy link
Collaborator

b4rtaz commented Sep 30, 2022

This branch has conflicts that must be resolved

@b4rtaz b4rtaz self-requested a review September 30, 2022 08:06
@ErnoW ErnoW merged commit 555883f into main Sep 30, 2022
@ErnoW ErnoW deleted the default-networkType branch September 30, 2022 08:26
@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants