fix: support not defined contractType for NFT types. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39f1025 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ErnoW
requested changes
Sep 16, 2022
| @@ -53,7 +53,7 @@ export class EvmNft implements MoralisDataObject { | |||
| static parse = (data: EvmNftInput, core: MoralisCore): EvmNftData => ({ | |||
| ...data, | |||
| chain: EvmChain.create(data.chain, core), | |||
| contractType: validateValidEvmContractType(data.contractType), | |||
| contractType: noramlizeEvmNftContractType(data.contractType), | |||
There was a problem hiding this comment.
Could we not just something like:
contractType: maybe(data.contractType, validateValidEvmContractType),
There was a problem hiding this comment.
In the previous version there is also a validation. I didn't change it.
https://github.com/MoralisWeb3/Moralis-JS-SDK/blob/main/packages/evmUtils/src/dataTypes/EvmNftContractType.ts
There was a problem hiding this comment.
Maybe it's not needed.
There was a problem hiding this comment.
I've standardized the code.
contractType: maybe(data.contractType, normalizeEvmNftContractType),
ErnoW
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: support not defined contractType for NFT types.