Move evm logic to evm utils #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: beaae52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b4rtaz
requested changes
Jul 22, 2022
Comment on lines
32
to
33
| "@ethersproject/bignumber": "^5.6.0", | ||
| "@ethersproject/units": "^5.6.0", |
There was a problem hiding this comment.
Do we need these dependencies here?
There was a problem hiding this comment.
Only as long as it is being used by the Sol datatypes in core.
Comment on lines
6
to
11
| if (!config.hasKey(EvmUtilsConfig.formatEvmAddress)) { | ||
| config.registerKey(EvmUtilsConfig.formatEvmAddress); | ||
| } | ||
|
|
||
| if (!config.hasKey(EvmUtilsConfig.formatEvmChainId)) { | ||
| config.registerKey(EvmUtilsConfig.formatEvmChainId); |
There was a problem hiding this comment.
I think this approach is wrong. This approach hides modules usage errors. You should get an error, if you use the module system in wrong way.
packages/evmUtils/src/test/setup.ts
Outdated
| import { MoralisCoreProvider } from '@moralisweb3/core'; | ||
| import { MoralisEvmUtils } from '../MoralisEvmUtils'; | ||
|
|
||
| export const setupEvm = () => { |
There was a problem hiding this comment.
Should be setupEvmUtils().
b4rtaz
approved these changes
Jul 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 'Pull request'
about: A new pull request
New Pull Request
Checklist
Issue Description
evm-utilsformatEvmAddressandformatEvmChainIdtoevm-utilsdefaultEvmApiChaintoevm-apiOther fixes/improvements
setupEvmApi