Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed jumping data + added keepPreviousData + added isPreviousData #1089

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

Y0moo
Copy link
Contributor

@Y0moo Y0moo commented Apr 10, 2023


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

Related issue: #FILL_THIS_OUT

Solution Description

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

🦋 Changeset detected

Latest commit: 8da9b38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@moralisweb3/react Patch
@moralisweb3/api-generator Patch
@moralisweb3/api-utils Patch
@moralisweb3/aptos-api Patch
@moralisweb3/auth Patch
@moralisweb3/codegen Patch
@moralisweb3/evm-api Patch
@moralisweb3/evm-utils Patch
@moralisweb3/next Patch
@moralisweb3/parse-server Patch
@moralisweb3/sol-api Patch
@moralisweb3/sol-utils Patch
@moralisweb3/streams Patch
@moralisweb3/test-utils Patch
@moralisweb3/common-aptos-utils Patch
@moralisweb3/common-auth-utils Patch
@moralisweb3/common-core Patch
@moralisweb3/common-evm-utils Patch
@moralisweb3/common-sol-utils Patch
@moralisweb3/common-streams-utils Patch
@moralisweb3/client-api-utils Patch
@moralisweb3/client-evm-api Patch
@moralisweb3/client-firebase-api-utils Patch
@moralisweb3/client-firebase-auth-utils Patch
@moralisweb3/client-firebase-evm-api Patch
@moralisweb3/client-firebase-evm-auth Patch
@moralisweb3/client-firebase-sol-api Patch
@moralisweb3/client-firebase-sol-auth Patch
@moralisweb3/client-sol-api Patch
@create-moralis-dapp/express Patch
@create-moralis-dapp/next Patch
@create-moralis-dapp/react-cra Patch
@create-moralis-dapp/react-vite Patch
@create-moralis-dapp/toolkit Patch
moralis Patch
create-moralis-dapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Y0moo Y0moo self-assigned this Apr 10, 2023
@github-actions
Copy link
Contributor

Test coverage

Title Lines Statements Branches Functions
api-utils Coverage: 30%
30.34% (61/201) 30.35% (17/56) 30.76% (12/39)
auth Coverage: 89%
92.38% (97/105) 83.33% (20/24) 86.2% (25/29)
evm-api Coverage: 100%
100% (89/89) 66.66% (6/9) 100% (57/57)
common-aptos-utils Coverage: 4%
4.87% (149/3056) 5.47% (25/457) 5.66% (45/794)
common-evm-utils Coverage: 70%
71.15% (1423/2000) 32.04% (314/980) 48.28% (393/814)
sol-api Coverage: 96%
96.66% (29/30) 66.66% (6/9) 91.66% (11/12)
common-sol-utils Coverage: 74%
74.55% (167/224) 66.66% (18/27) 65.38% (51/78)
common-streams-utils Coverage: 91%
91.42% (1184/1295) 77.57% (415/535) 82.08% (426/519)
streams Coverage: 88%
88.19% (575/652) 68.81% (64/93) 87.94% (124/141)

@Y0moo Y0moo marked this pull request as ready for review April 10, 2023 12:27
@Y0moo Y0moo requested a review from a team as a code owner April 10, 2023 12:27
@b4rtaz
Copy link
Collaborator

b4rtaz commented Apr 11, 2023

It looks fine. Would be nice to have a test that covers this case.

@Y0moo Y0moo merged commit c96d1de into main Apr 11, 2023
@Y0moo Y0moo deleted the react-jumping-data branch April 11, 2023 08:57
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants