Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Fix typo in macros.yml #47

Merged

Conversation

sp-tkerlavage
Copy link
Contributor

There's a typo in the macros.yml file. This raises a warning when a project that uses this package is invoked.

  • [WARNING]: Found patch for macro "grant_ownershop_on_schema_objects" which was not found

…roject that uses this package is invoked.

* [WARNING]: Found patch for macro "grant_ownershop_on_schema_objects" which was not found
@sp-tkerlavage sp-tkerlavage changed the title Fix typo Feat/Fix typo in macros.yml Oct 28, 2023
@calleo
Copy link
Contributor

calleo commented Nov 8, 2023

You might also want to add something like DBT_WARN_ERROR_OPTIONS='{"include": "all"}' to the build pipeline to avoid warnings like this slipping through. Ping @JFrackson

@bbrewington
Copy link

What is the plan to get this PR merged? Could this go into release version 0.6.2 since it's just docs & non-breaking?

@bbrewington
Copy link

@JFrackson ^ asking about plan for releasing this PR, and forgot to "@" you in previous comment

@JFrackson JFrackson self-requested a review January 15, 2024 23:01
@JFrackson JFrackson merged commit 3d72c29 into Montreal-Analytics:master Jan 15, 2024
@JFrackson
Copy link
Contributor

Thanks for this fix and sorry for the delay with the review! We'd definitely like to add better CI/CD to this project and this is just one part of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants