Add the possibility to disable ldap password stored in DB

[Pbast]

Hello,
Since release 0.4 LDAP authentication store LDAP password in DB and this way is against our security policies.
I'm a newbie in python langage but I can try to add a new setting to disable this storing.
For this could you show me pieces of code about this issue #21 ?
Thxs.
Pascal B

[madmath03]

Hello,

Sorry for the delay.
Here are a few tips on what should be done to develop this feature:

The password is saved in services.py so this is the only Python file you will need to update:

• First thing to do will be to get a new attribute (LDAP_SAVE_LOGIN_PASSWORD with default to True) at the start of the file to define the expected behavior:

  taiga-contrib-ldap-auth-ext/taiga_contrib_ldap_auth_ext/services.py

  Lines 27 to 32 in 9fe8b10

  	FALLBACK = getattr(settings, 'LDAP_FALLBACK', 'normal')
  	SLUGIFY = getattr(settings, 'LDAP_MAP_USERNAME_TO_UID', '')
  	EMAIL_MAP = getattr(settings, 'LDAP_MAP_EMAIL', '')
  	NAME_MAP = getattr(settings, 'LDAP_MAP_NAME', '')

• Then, you will need to encapsulate the code setting the user password on first login with a condition depending on the parameter you loaded earlier:

  taiga-contrib-ldap-auth-ext/taiga_contrib_ldap_auth_ext/services.py

  Lines 115 to 117 in 9fe8b10

  	# Set local password to match LDAP (issues/21)
  	user.set_password(password)
  	user.save()

• Then, do the same for an already existing user. You could even add an else condition to forcefully set the user password to None to ensure that the password is removed from already existing users:

  taiga-contrib-ldap-auth-ext/taiga_contrib_ldap_auth_ext/services.py

  Lines 122 to 124 in 9fe8b10

  	# Set local password to match LDAP (issues/21)
  	user.set_password(password)
  	user.save()

• Last but not least, update the sample configuration in the README.md to show how to disable the password synchronization : something like LDAP_SAVE_LOGIN_PASSWORD = False with a small comment and maybe link to issue

That's pretty all there is to it.

Do not hesitate to open the PR even if your work is not finished. I can help you review your code while your PR is in progress.