Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FT] Add ReplacementsDict and ValidReplacementValue types for smtp replacements #50

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

J1Loop
Copy link
Contributor

@J1Loop J1Loop commented Nov 14, 2024

New Types for Template Replacements Validation:

  • Added ReplacementsDict TypedDict and ValidReplacementValue Union type to quipus/utils/types.py for validating template replacements.

Updates to __init__.py:

  • Updated quipus/__init__.py to include the new ReplacementsDict and ValidReplacementValue in the imports and __all__ list.
  • Updated quipus/utils/__init__.py to export the new types.

Updates to smtp_delivery.py:

  • Imported ReplacementsDict and ValidReplacementValue in quipus/services/smtp_delivery.py.
  • Modified the with_body_path method to use Optional[dict[str, ValidReplacementValue]] for the replacements parameter and added type checks for replacement values.

@J1Loop J1Loop added enhancement New feature or request fix Something got fixed labels Nov 14, 2024
@J1Loop J1Loop requested a review from pandasoncode November 14, 2024 11:13
@J1Loop J1Loop self-assigned this Nov 14, 2024
Copy link
Contributor

@pandasoncode pandasoncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@J1Loop J1Loop merged commit c2842ab into main Nov 14, 2024
2 checks passed
@J1Loop J1Loop deleted the fix/smtp-replace branch November 14, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix Something got fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants