Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives the Sig Tech access to the Request Console Announcements, adds console to Telecomms #4240

Merged
merged 6 commits into from
Dec 2, 2024

Conversation

Wisemonster
Copy link
Collaborator

@Wisemonster Wisemonster commented Nov 14, 2024

About The Pull Request

Gives the signal technician access to the request console announcement system, and adds them to telecomms on maps that were missing them.

Why It's Good For The Game

Allows the signal technician to relay information about the current state of tcomms to the rest of the crew, and map consistency.

Changelog

🆑
add: Added a request console boards to the telecomms of Blueshift, Delta, Meta, and Theseus.
balance: Signal Technicians can now use the request consoles' announcement system
/:cl:

@Wisemonster Wisemonster changed the title Gives the SIg Tech access to the Request Console Announcements, adds console to Telecomms Gives the Sig Tech access to the Request Console Announcements, adds console to Telecomms Nov 14, 2024
@@ -3048,6 +3048,9 @@
/area/station/science/genetics)
"aFb" = (
/obj/structure/reagent_dispensers/water_cooler,
/obj/machinery/requests_console/directional/north{
name = "Telecomms Requests Console"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like it's set to let them send announcements using it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, should be fixed along with the other maps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the desk name when it announces? I forgot if it goes by the name of the request console but like how QM announcement is "Quartermasters Desk", telecoms admin is generally "Telecomms Admin" announcements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's the department var

Copy link
Member

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the department var of the tcomms requests consoles to "Telecomms Admin" or something

@Wisemonster
Copy link
Collaborator Author

Alright, I changed their department to telecomms admin, and gave ouroboros a board.

Copy link
Member

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Absolucy Absolucy merged commit 6359686 into Monkestation:master Dec 2, 2024
24 checks passed
github-actions bot added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants