[BOUNTY] Nanotrasen Representative #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
SirNightKnight
changed the title
Absolucy
previously requested changes
Oct 21, 2024
There was a problem hiding this comment.
monkestation/code/modules/NTrep/clothing/nanotrasen_representative_clothing-digi.dmi
monkestation/code/modules/NTrep/clothing/nanotrasen_representative_clothing.dmi
monkestation/code/modules/NTrep/clothing/nanotrasen_representative_clothing_item.dmi
No. Gonna start putting my foot down - icons go in the monkestation/icons folder, do not put icons in the code folder.
Also, CI is failing:
Error: Missing inhand sprites for /obj/item/clothing/head/hats/nanotrasen_representative in both 'icons/mob/inhands/clothing/hats_lefthand.dmi' & 'icons/mob/inhands/clothing/hats_righthand.dmi'.
inhand_icon_state = "dg_suit" - Matching sprite found in: 'icons/mob/inhands/clothing/suits_lefthand.dmi' & 'icons/mob/inhands/clothing/suits_righthand.dmi'
FAILURE #1: Missing inhand sprites for /obj/item/clothing/head/hats/nanotrasen_representative in both 'icons/mob/inhands/clothing/hats_lefthand.dmi' & 'icons/mob/inhands/clothing/hats_righthand.dmi'.
inhand_icon_state = "dg_suit" - Matching sprite found in: 'icons/mob/inhands/clothing/suits_lefthand.dmi' & 'icons/mob/inhands/clothing/suits_righthand.dmi' at code/modules/unit_tests/inhands.dm:88
ThePooba
dismissed
Absolucy’s stale review
How do i mark a review as completed lmao
This was referenced Oct 26, 2024
Absolucy
changed the title
This was referenced Oct 26, 2024
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds the Nanotrasen Representative job and several items for them including the Plasmacore laser gun, clothing, special briefcase full of cash, and stolen garment bag.
The job should need 50 central command hours to unlock.
Sprite work by the amazing CannibalHunter.
Things that look like bugs but aren't
Their ID trim is not a template in the ID painter and they don't have a spare headset in their locker. This was done for security reasons.
Why It's Good For The Game
Ook wanted it and it has a LOT of RP potential
Changelog
🆑
change: Blueshields now answer to Central Command and the Nanotrasen Representative
code: Renamed the "Nanotrasen Consultant's Office" area to "Nanotrasen Representative's Office"
code: Added a landmark for the Nanotrasen Representative
add: Nanotrasen has pushed their representatives to work onboard the station to make sure Standard Operating Procedure is followed and company interests are upheld.
/:cl: