Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fax Changes, Remote Armed Robbery, Admin Fax Machines, and more! #3793

Merged
merged 11 commits into from
Nov 6, 2024

Conversation

Noot-Toot
Copy link
Contributor

@Noot-Toot Noot-Toot commented Oct 14, 2024

About The Pull Request

This PR changes a multitude of stuff relating to Fax Machines

  1. You can send more shit through if you hack a input servo
  2. Fax machines can no longer jam by sending hacked servo items.
  3. Made the "you can only send paper to NT" message clearer
  4. Admins can now set their fax machines to message admins when something comes through.

Why It's Good For The Game

  1. Its funny
  2. It was somewhat annoying if you wanted to send pizza through a fax machine.
  3. it was kinda confusing? seems clearer now.
  4. what good are admin fax machines if the admins dont even know when something happens concerning them?

Changelog

🆑 Tractor Mann
add: You can fax more things now! hack a fax machines input servo to send banana peels, commit remote armed robbery and more!
del: Fax machines can no longer jam.
spellcheck: the paper only message for NT faxes has been changed.
admin: fax machines can now have recieve_notifies_admins set so you dont have to always keep a eye on your fax machine.
/:cl:

Add recieve_notifies_admins which lets centcom faxes be actually admin.
Add more exotic faxes, most of which entirely forego the original coders idea of "generally flat stuff" but its funny so it doesnt matter
changes the paper only message for NT faxes
Disables jamming.
minor spelling mistake, i am instantly eviscerated for my crimes.
adds in a few icons for the sent/recieved items, specifically the gun, handcuffs and peel. as you can tell i am no artist.
@RandomDudeFromTheRim
Copy link
Contributor

RandomDudeFromTheRim commented Oct 14, 2024

all fun and games until people figure out that with 300 monkecoins you can breach into anywhere where there is a fax just with an another fax, some tools and a second person (atleast if amogus'd people are considered mob_holder as an item, that is)

image

@Noot-Toot
Copy link
Contributor Author

all fun and games until people figure out that with 300 monkecoins you can breach into anywhere where there is a fax just with an another fax, some tools and a second person (atleast if amogus'd people are considered mob_holder as an item, that is)

image

Unfortunatley for me, they are! Which even more unfortunately, Makes this a centcom entry method. This is why we cant have nice things (faxed mothroaches).

unfortunately, this let amogi players be faxed to centcom. which is REALLY bad. like SUUUPER bad.
fortunately, this now by technicality gives all the faxes i added icons because the only one without now no longer exists.
@RandomDudeFromTheRim
Copy link
Contributor

F

@RandomDudeFromTheRim
Copy link
Contributor

RandomDudeFromTheRim commented Oct 14, 2024

all fun and games until people figure out that with 300 monkecoins you can breach into anywhere where there is a fax just with an another fax, some tools and a second person (atleast if amogus'd people are considered mob_holder as an item, that is)
image

Unfortunatley for me, they are! Which even more unfortunately, Makes this a centcom entry method. This is why we cant have nice things (faxed mothroaches).

if you really want faxed mothroaches, I guess why not add pet beacon in?
EDIT: also, redo the changelog if you aint gonna do that, since it lies that you can 'send pets'
EDIT 2: don't thank me for aux fix :P

readded the power to fax pets/amogi (amogi part unintentional its just coded that way) BUT this time, you cant fax to centcom! trying to send a fax to centcom will fail. Also adds a admin subtype to faxes that come with hacking already AND notifies admins when it recieves letters
because it was voted for on a poll on discord, sure it only has 2 votes and has 23 hours left, but i can just change it back if need be.
i immediately miss the button and am shot on the spot (forgot a ,)
@wraith-54321
Copy link
Collaborator

while your at it can you make normal paper not get the chem holder component? it makes it so you cant fax people C4 because when you try and put it onto the paper it instead turns into a "C4" rollie

@Noot-Toot
Copy link
Contributor Author

Noot-Toot commented Oct 16, 2024

while your at it can you make normal paper not get the chem holder component? it makes it so you cant fax people C4 because when you try and put it onto the paper it instead turns into a "C4" rollie

Just making sure, you want me to comment out the AddComponent section of paper init code yeah?

/obj/item/paper/Initialize(mapload)
        . = ..()
        AddComponent(/datum/component/customizable_reagent_holder, /obj/item/clothing/mask/cigarette/rollie, CUSTOM_INGREDIENT_ICON_NOCHANGE, ingredient_type=CUSTOM_INGREDIENT_TYPE_DRYABLE, max_ingredients=2, job_xp = 1, job = JOB_BOTANIST)

Theres also contact poison vars which idk if this will effect dont even have functionalities to add anything to them ingame so it doesnt matter

tested and works, C4 on regular paper plants it, C4 on rolling paper still becomes a blunt but thats ok.
guess who went back on "should be everything in my pr done" again!
@@ -48,6 +50,17 @@ GLOBAL_VAR_INIT(nt_fax_department, pick("NT HR Department", "NT Legal Department
/obj/item/holochip,
/obj/item/card,
/obj/item/folder/biscuit,
//MONKESTATION EDIT START, also edits icons/obj/fax.dmi
/obj/item/clothing/head/mob_holder, //if i could it'd just be mothroaches but they ALL use this.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me when I fax an amongus person to centcom

Copy link
Contributor Author

@Noot-Toot Noot-Toot Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are later down the code (ln 351) specifically to prevent faxing people into cc, should work as it did last i tested

@@ -72,7 +72,7 @@

/obj/item/paper/Initialize(mapload)
. = ..()
AddComponent(/datum/component/customizable_reagent_holder, /obj/item/clothing/mask/cigarette/rollie, CUSTOM_INGREDIENT_ICON_NOCHANGE, ingredient_type=CUSTOM_INGREDIENT_TYPE_DRYABLE, max_ingredients=2, job_xp = 1, job = JOB_BOTANIST)
//AddComponent(/datum/component/customizable_reagent_holder, /obj/item/clothing/mask/cigarette/rollie, CUSTOM_INGREDIENT_ICON_NOCHANGE, ingredient_type=CUSTOM_INGREDIENT_TYPE_DRYABLE, max_ingredients=2, job_xp = 1, job = JOB_BOTANIST) //MONKESTATION REMOVAL: fix adding C4 on paper
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue with this is that it breaks making blunts

Copy link
Contributor Author

@Noot-Toot Noot-Toot Oct 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obj/item/rollingpaper, printable from biogens, still exists which this doesnt effect, was also wraiths request so i could probably just remove it if its a issue with the pr

@ThePooba
Copy link
Collaborator

we actually removed the fax machines at centcom because of this shit

the issues brought up were already solved, but i just want this PR through
I gotta get these PRs outta my house by sunday, im having a potluck! do you have any idea whatll happen if they see all these PRs in my house? HOW EMBARRASING!
there was 2 breadslices in the list. whoopsie!
This was referenced Nov 3, 2024
@ThePooba ThePooba merged commit 375747f into Monkestation:master Nov 6, 2024
23 checks passed
github-actions bot added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants