-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fax Changes, Remote Armed Robbery, Admin Fax Machines, and more! #3793
Conversation
Add recieve_notifies_admins which lets centcom faxes be actually admin. Add more exotic faxes, most of which entirely forego the original coders idea of "generally flat stuff" but its funny so it doesnt matter changes the paper only message for NT faxes Disables jamming.
Unfortunatley for me, they are! Which even more unfortunately, Makes this a centcom entry method. This is why we cant have nice things (faxed mothroaches). |
unfortunately, this let amogi players be faxed to centcom. which is REALLY bad. like SUUUPER bad. fortunately, this now by technicality gives all the faxes i added icons because the only one without now no longer exists.
F |
readded the power to fax pets/amogi (amogi part unintentional its just coded that way) BUT this time, you cant fax to centcom! trying to send a fax to centcom will fail. Also adds a admin subtype to faxes that come with hacking already AND notifies admins when it recieves letters
i immediately miss the button and am shot on the spot (forgot a ,)
while your at it can you make normal paper not get the chem holder component? it makes it so you cant fax people C4 because when you try and put it onto the paper it instead turns into a "C4" rollie |
Just making sure, you want me to comment out the AddComponent section of paper init code yeah?
Theres also contact poison vars which |
tested and works, C4 on regular paper plants it, C4 on rolling paper still becomes a blunt but thats ok.
guess who went back on "should be everything in my pr done" again!
code/modules/paperwork/fax.dm
Outdated
@@ -48,6 +50,17 @@ GLOBAL_VAR_INIT(nt_fax_department, pick("NT HR Department", "NT Legal Department | |||
/obj/item/holochip, | |||
/obj/item/card, | |||
/obj/item/folder/biscuit, | |||
//MONKESTATION EDIT START, also edits icons/obj/fax.dmi | |||
/obj/item/clothing/head/mob_holder, //if i could it'd just be mothroaches but they ALL use this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me when I fax an amongus person to centcom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks are later down the code (ln 351) specifically to prevent faxing people into cc, should work as it did last i tested
code/modules/paperwork/paper.dm
Outdated
@@ -72,7 +72,7 @@ | |||
|
|||
/obj/item/paper/Initialize(mapload) | |||
. = ..() | |||
AddComponent(/datum/component/customizable_reagent_holder, /obj/item/clothing/mask/cigarette/rollie, CUSTOM_INGREDIENT_ICON_NOCHANGE, ingredient_type=CUSTOM_INGREDIENT_TYPE_DRYABLE, max_ingredients=2, job_xp = 1, job = JOB_BOTANIST) | |||
//AddComponent(/datum/component/customizable_reagent_holder, /obj/item/clothing/mask/cigarette/rollie, CUSTOM_INGREDIENT_ICON_NOCHANGE, ingredient_type=CUSTOM_INGREDIENT_TYPE_DRYABLE, max_ingredients=2, job_xp = 1, job = JOB_BOTANIST) //MONKESTATION REMOVAL: fix adding C4 on paper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue with this is that it breaks making blunts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obj/item/rollingpaper, printable from biogens, still exists which this doesnt effect, was also wraiths request so i could probably just remove it if its a issue with the pr
we actually removed the fax machines at centcom because of this shit |
there was 2 breadslices in the list. whoopsie!
About The Pull Request
This PR changes a multitude of stuff relating to Fax Machines
Why It's Good For The Game
Changelog
🆑 Tractor Mann
add: You can fax more things now! hack a fax machines input servo to send banana peels, commit remote armed robbery and more!
del: Fax machines can no longer jam.
spellcheck: the paper only message for NT faxes has been changed.
admin: fax machines can now have recieve_notifies_admins set so you dont have to always keep a eye on your fax machine.
/:cl: