[PORT] playsound() will runtime if you try to pass a list into it #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Adds an islist() sanity check and runtime to playsound() to prevent client crashing. ## Why It's Good For The Game Clients have a possibility to crash if you pass a list() into playsound() without runtimming. It's sporadic. It's not consistant. I've not managed to reproduce it on local. But monkey ran into this issue before and I've ran into this issue if you forget to use pick() Plus there should honestly just be something to tell people to not pass lists into something that plays a single sound. ## Changelog Not player facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Port of tgstation/tgstation#86934
Adds an islist() sanity check and runtime to playsound() to prevent client crashing.
Why It's Good For The Game
avoids a situation like #2923 happening again
Changelog
Not player facing