Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heretic sacrifice refactor! #3279

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Sep 8, 2024

Changelog

🆑
refactor: Refactored heretic sacrifices to track minds instead of bodies.
fix: Heretics can now properly sacrifice oozeling cores.
fix: Heretic sacrifice targets will still be valid if they somehow change bodies, i.e if they're cloned.
qol: Heretic roundend report will now bold the names of targets who were actually sacrificed.
qol: Heretics will no longer roll off-station, non-crew, disconnected, or AFK players as targets.
/:cl:

@destrucktoid
Copy link

Doesn't this mean that if i get killed by a heretic and DNR myself i can prevent them from sacrificing me? Since the target no longer has a mind.

@destrucktoid
Copy link

destrucktoid commented Sep 9, 2024

Also it's unclear in the code from what i can read, does this remove people who are AFK from your target list if they are already there? If it does then surely if i disconnect from the server after i get killed i could remove myself from your sacrifice list?

@Absolucy
Copy link
Member Author

Absolucy commented Sep 9, 2024

@destrucktoid

  • i think you still have mind, and it also checks last_mind anyways. mind never gets delete i think
  • it just won't select people who are afk during the initial selection process - they still stay a target if they disconnect/afk after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants