Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the storyteller matter even after the 85minute mark #3091

Closed

Conversation

Marabout2
Copy link
Contributor

About The Pull Request

There was a variable set to true that removed all checks for antag to spawn after the 85 minute, I've set it to false

Why It's Good For The Game

Actually make long rounds not go into the shitter instantly by the gazillion antag and actually make the storyteller matter

Changelog

set a variable to false in event.dm to actually let the storyteller still matter even after the 85 minute mark

🆑

code: event.dm got a variable set to false instead of true, stopping the gazillion antag roll after the 85 minute mark.

/:cl:

@XeonMations
Copy link

Was thinking of making this variable controlled imo, maybe even a server config, since MRP could technically still want this

@dwasint
Copy link
Collaborator

dwasint commented Aug 23, 2024

as per disscussions with ook its removed at 85 minutes because the average round is intended to be an hour and a half will pass this around for more discussions with admins though

@Absolucy
Copy link
Member

@dwasint imo there's prolly a better solution than just "start throwing one morbillion antags at the station" - maybe a crew transfer vote or something at the 85 min mark?

@KnigTheThrasher
Copy link
Contributor

@dwasint imo there's prolly a better solution than just "start throwing one morbillion antags at the station" - maybe a crew transfer vote or something at the 85 min mark?

this was tried earlier this year and people used it to speedrun shuttle calls

@Absolucy
Copy link
Member

i mean, they wouldn't be able to be started manually by crew?

@wraith-54321
Copy link
Collaborator

yeah currently this PR makes ghost roles unable to roll after this point, it would have to just remove the check to undo it

@Absolucy
Copy link
Member

Seems that #3278 is the preferred solution to this by Ook and others

@Absolucy Absolucy closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants