attempt 2 #2
Closed
attempt 2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwasint
force-pushed
the
wowie-love-this
branch
from
c659862 to
b0bfdd0
Compare
dwasint
referenced
this pull request
in dwasint/Monkestation2.0
Aug 22, 2023
…nent (#77539) Hey there, I've personally fallen for this stupid thing twice (in #77503 and #75627 (d357516)), so I decided to spend a few hours to crack out a unit test to ensure that I (and no one else) falls for this stupid thing again. Let me know if there's a smarter way to code something like this, but I couldn't figure out a better way to accomodate the current framework and be as agnostic to certain oddities as possible. Catches stuff like this: ```txt [2023-08-11 21:10:04.019] FAILURE #1: The mob Garden Gnome does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE #2: The mob the morph does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE #3: The mob the guard spiderling (946) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#4: The mob the ambush spiderling (255) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#5: The mob the scout spiderling (375) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#6: The mob the flesh spiderling (337) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#7: The mob the hunter spiderling (869) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#8: The mob the nurse spiderling (629) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#9: The mob the tangle spiderling (19) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#10: The mob the broodmother spiderling (855) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#11: The mob the viper spiderling (519) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#12: The mob the tarantula spiderling (963) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#13: The mob the spiderling (100) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 ``` (ignore the part about gnomes and morphs, this was an earlier version of the unit test. everything else was relevant and is fixed) :cl: fix: Growing spiders will now retaliate against you like they were always meant to. /:cl:
Closed
dwasint
added a commit
that referenced
this pull request
Dec 14, 2023
Mining RND #2 : New PKA Varients
DexeeXI
added a commit
to DexeeXI/Monkestation2.0
that referenced
this pull request
Apr 16, 2024
HA, it needs to be tied to EACH PLASMAMAN HELMET.
OliverOtter
added a commit
to OliverOtter/Monkestation2.0Codingstuff
that referenced
this pull request
Oct 28, 2024
ThePooba
added a commit
that referenced
this pull request
Oct 30, 2024
Revert "Automatic TGS DMAPI Update"
ThePooba
pushed a commit
that referenced
this pull request
Oct 31, 2024
* simians are subtypes of monkey * Update humans.dm * Create screenshot_humanoids__datum_species_monkey_simian.png * Update high_five.dm * Revert "Update high_five.dm" This reverts commit 3585b0a. * Fixes simian eyes & pref page image * monkey tail pref icon * Update head.dm * screenshot tests * Update simian.dm * Update simian.dm * Update screenshot_humanoids__datum_species_monkey_simian.png * now advancedtoolusers * ports how TG handles applying height filters This makes it not work in pref menu properly but should hopefully cut down on the amount of times it gets called. * takes the lazy way out to fix hats * all hail the one line fixes * Fixes butchering monkeys/simians * Simian gags is kil * teratomas cant use monkey parts anymore * Adds comments for non modular changes * Fixes belts looking off * Update simian.dm * Monkeys now have fur and eyes * Update monkestation/code/game/objects/items/translation_hat.dm Co-authored-by: wraith-54321 <[email protected]> * updated screenshot tests * cuts down on unnecessary things * Update _species.dm * Less unnecessary calls for updating bodies Monkestation seems to have a lot of unnecessary calls to update body, this cuts down on a few of them. TG's species-nuking PRs might be good to help against this. * one less call to update body parts * Hopefully cuts down more on needless calls By fully reverting a PR (#363) that became non functional after a few big port PRs overwrote the stuff it did, creating a mess. * Update body.dm * removes double regenerate icons call * no need to update body parts every time we change prefs --------- Co-authored-by: wraith-54321 <[email protected]>
Addust
added a commit
to addusts-shenanigans/I-am-going-to-defenestrate-myself
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Mapping March
Ckey to receive rewards: N/A
Why It's Good For The Game
Changelog
🆑
/:cl: