Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontier modsuit isn't considered airtight for internals. #3606

Closed
MonkestationIssueBot opened this issue Sep 29, 2024 · 0 comments · Fixed by #3618
Closed

Frontier modsuit isn't considered airtight for internals. #3606

MonkestationIssueBot opened this issue Sep 29, 2024 · 0 comments · Fixed by #3618

Comments

@MonkestationIssueBot
Copy link

MonkestationIssueBot commented Sep 29, 2024 •
edited by github-actions bot
Loading

Reporting client info: Client Information:
BYOND:515.1642
Key:icetype

Round ID:

7071

Testmerges:

Reproduction:

Title
Shoddd added a commit to Shoddd/MonkeShod that referenced this issue Sep 30, 2024
@Shoddd
Makes frontier modsuit helmet airtight
a5ae8b5 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull request process. -->

## About The Pull Request
fixes Monkestation#3606
<!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! -->

## Why It's Good For The Game
Space helmet, space worthy, airtight, not internal worthy??
<!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. -->

:cl:
fix: frontier modsuit helmet now airtight
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
@Shoddd Shoddd mentioned this issue Sep 30, 2024
Merged
@Gw0sty Gw0sty mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makes frontier modsuit helmet airtight Shoddd/MonkeShod
1 participant
@MonkestationIssueBot