[contributing] [story] rework of "Knock" story, on #8657 #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: <[email protected]> Co-authored-by: <[email protected]>
lunulae
approved these changes
Sep 11, 2022
multimokia
approved these changes
Sep 11, 2022
|
Wait! Why did it get merged into master and is missing all expression? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i chatted with multimokia at the contributor discord server and we decided a whole rewrite of the pr #8657 should be made so i attempted it. the story in which i based myself on can be read here. i haven't added expressions, so we can change dialogue more freely first. i can do that later, though! if any writing changes must be done, let me know too. thanks!