Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more NOU improvements #9379

Merged
merged 12 commits into from
Sep 18, 2022
Merged

Conversation

Booplicate
Copy link
Member

@Booplicate Booplicate commented Jul 24, 2022

Changes:

  • Allow to ask to change house rules after the game is over
  • Delayed desk sprite init to init 500, also guardrailed global map access with a try/except
  • Fixed an issue where Monika wouldn't start a minigame she picked in the mas_mood_bored event
  • Implemented a new house rules thanks to @Legendkiller21
    • Allows to reflect a +2 or +4 with a +4, and reflect skips using a skip of any colour

Testing:

  • Test the new way of changing house rules
    • After Monika wins a game with points
    • After player wins a game with points
    • After Monika wins a game without points
    • After player wins a game without points
      • For all of the above, test both cases where you continue to play AND leave after changing the rules
      • You can use renpy.get_return_stack() to verify we're not adding an extra call stack
  • Verify desk sprites still work as before
  • Verify Monika can start any game from mas_mood_bored and the games have correct names (NOU should be capitalised, the rest not)
  • Verify the new house rule works and Monika still plays good with and without it

@Booplicate Booplicate added awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Jul 24, 2022
@Booplicate Booplicate added this to the Next Release milestone Jul 24, 2022
This is to account for the garden view issue
@Booplicate Booplicate linked an issue Jul 24, 2022 that may be closed by this pull request
@Booplicate Booplicate linked an issue Jul 24, 2022 that may be closed by this pull request
Booplicate and others added 5 commits July 24, 2022 16:24
Now it will work with all new added games w/o manually adding them
This is for the new reflect_chaos rule
So we don't have to check for each rule explicitly
@Booplicate Booplicate marked this pull request as ready for review July 24, 2022 15:59
@ThePotatoGuy ThePotatoGuy merged commit f8f8b7a into Monika-After-Story:content Sep 18, 2022
@ThePotatoGuy ThePotatoGuy removed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Sep 18, 2022
@Booplicate Booplicate linked an issue Sep 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

House rule suggestion for NOU [Bug] - Error while trying to plau NOU (Suggestion) A extra option in 'NOU'
3 participants