Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fun fact] maple syrup #8253

Merged
merged 7 commits into from
Dec 23, 2021
Merged

Conversation

KansaiGal
Copy link
Contributor

Well, I /wanted/ to add:

            random=False,
            conditional=(
                "persistent._mas_pm_gets_snow is not False "
                "and mas_isWinter()"
            ),

to a fun fact, but it doesn't seem to work when I tested it.
Any help on that would be appreciated.

@jmwall24
Copy link
Member

I actually don't think it needs that. Only the very end needs that check, so i'll just add it there to path the end.

Co-Authored-By: KansaiGal <[email protected]>
@jmwall24 jmwall24 added awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested labels Nov 14, 2021
Copy link
Member

@multimokia multimokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some consistency things

Monika After Story/game/script-fun-facts.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-fun-facts.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-fun-facts.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-fun-facts.rpy Outdated Show resolved Hide resolved
@KansaiGal KansaiGal requested a review from multimokia December 23, 2021 16:48
multimokia
multimokia previously approved these changes Dec 23, 2021
@multimokia multimokia removed awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Dec 23, 2021
@multimokia multimokia merged commit d3c8728 into Monika-After-Story:content Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants