-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag replacement to Image Tag Decorations #7145
Add tag replacement to Image Tag Decorations #7145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You deprecated mas_isDecoTagVisible
, but it's still being used in a few places. I'd probably even replace it with mas_isDecoTagShowing
in mas_d25_monika_christmas
.
Should we handle this now or later?
Looking at the other spots its used, it seems like Visible should just mean Showing, so instead just changing the meaning of the function instead of deprecating. |
Key Changes
replace_tag
param to theregister_bg
/register_img
/register_img_same
functionsmas_isDecoTagVisible
now means that the decoration (or replacment tag) is actually showing, not just when its enabled.show_now
orhide_now
params didn't show/hide the deco at all.Testing
TEST DECO ADF
dev topic