Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag replacement to Image Tag Decorations #7145

Merged
merged 10 commits into from
Sep 13, 2021

Conversation

ThePotatoGuy
Copy link
Member

@ThePotatoGuy ThePotatoGuy commented Apr 2, 2021

Key Changes

  • Adds using a different image tag for a decoration depending on background
  • deco definitions per background now include a replacement tag in addition to the frame
  • to use replacement tag functionality, pass in a replace_tag param to the register_bg/register_img/register_img_same functions
  • The deco ADF test topic has been updated with an example of tag replacement in operation
  • mas_isDecoTagVisible now means that the decoration (or replacment tag) is actually showing, not just when its enabled.
  • fixed issue where showing/hiding deco without the show_now or hide_now params didn't show/hide the deco at all.

Testing

  • test the TEST DECO ADF dev topic

@ThePotatoGuy ThePotatoGuy self-assigned this Apr 2, 2021
@ThePotatoGuy ThePotatoGuy marked this pull request as ready for review September 2, 2021 02:59
@ThePotatoGuy ThePotatoGuy added awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested labels Sep 2, 2021
@ThePotatoGuy ThePotatoGuy added this to the Next Release milestone Sep 2, 2021
multimokia
multimokia previously approved these changes Sep 4, 2021
@Booplicate Booplicate added the requires wiki updates the wiki needs an update in some way because of this pr label Sep 4, 2021
Copy link
Member

@Booplicate Booplicate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deprecated mas_isDecoTagVisible, but it's still being used in a few places. I'd probably even replace it with mas_isDecoTagShowing in mas_d25_monika_christmas.

Should we handle this now or later?

@ThePotatoGuy
Copy link
Member Author

Looking at the other spots its used, it seems like Visible should just mean Showing, so instead just changing the meaning of the function instead of deprecating.

@multimokia multimokia merged commit f083d46 into Monika-After-Story:content Sep 13, 2021
@Booplicate Booplicate removed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires wiki updates the wiki needs an update in some way because of this pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants