-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dissolve for idle disp and more #6986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got this traceback while running but pretty sure its related to something else.
While running game code:
File "game/script-ch30.rpy", line 1513, in script
$ mas_randchat.wait()
File "game/script-ch30.rpy", line 1513, in <module>
$ mas_randchat.wait()
File "game/definitions.rpy", line 8273, in wait
renpy.pause(WAITING_TIME, hard=True)
File "game/sprite-chart.rpy", line 8205, in render
img_render = renpy.render(self.current_img, width, height, self.current_st, at)
File "game/sprite-chart.rpy", line 8753, in render
mouse_pos = store.mas_windowutils.getMousePosRelative()
AttributeError: 'StoreModule' object has no attribute 'getMousePosRelative'
The PR that adds that method hasn't been merged yet. For testing I just chucked it into a temp rpy. This shouldn't be merged 'til we get #7006 though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to me that she blinks more often when advancing dialogue after a line completes. Also these blinks seem much faster than normal to the point where it feels like flickering. I'll hold off on a full approval until @multimokia and @jmwall24 take a look at the feel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would these new changes potentially cause issues if we had two monika sprites on the screen at the same time?
All Monikas would blink in sync which would look bad, but our current system doesn't allow to show 2 Monikas anyway. Are we going to do it in the future? |
its an option under consideration in #5026. but we could probably just force one to be static. |
I wanted to add dissolves for the idle disp from the get go, but didn't have time for it, so I'm doing it now. With these changes (and ideally with an r7 upgrade) all Monika's sprites will use a nice, smooth transition.
Changes:
Dissolve
transition for Monika's idle displayable. The timings are:0.25
sec for a pose change,0.1
sec for an exp change.Dissolve
transitions for blinking, winks, and tears. The duration for all of them is0.1
sec (for many of those we can't use more than that, although we could use different durations if we wanted to, leaving this to the testers).MASMoniIdleDisp
got the newskip_dissolve
parameter. It allows us to skip the transition during the next exp change.Dissolve
s and is more optimized than the currentConditionSwitch
. NOTE: uses a method from Windowreacts but they're implemented how they should've been from the start #7006.Fixes:
MASMonikaRender
.We don't usescene
in thespaceroom
label anymore. RenPy has a bug with images being used in bothold_widget
andnew_widget
of a transform (Dissolve
in this case). Sincescene
is hiding images, it adds them toold_widget
, then we're showing them, it adds them tonew_widget
. Because of that the images are gettingst
andat
for both states at once.Testing:
show
en directly.