Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Stories System #6639

Merged
merged 18 commits into from
Jan 17, 2021
Merged

Better Stories System #6639

merged 18 commits into from
Jan 17, 2021

Conversation

multimokia
Copy link
Member

Stories now use a more dynamic system. Featuring less redundant code and actually working return keys for A new story (#6637)

Testing:

  • Verify stories still work properly
  • Verify unlocking stories still works properly
  • Verify return keys work on stories accessed via A new story

@multimokia multimokia added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Nov 4, 2020
@multimokia multimokia added this to the 0.11.7 milestone Nov 4, 2020
@multimokia multimokia linked an issue Nov 4, 2020 that may be closed by this pull request
(Bug) No "I love you too!" #6637
Closed
ThePotatoGuy
ThePotatoGuy previously approved these changes Nov 8, 2020
View reviewed changes
@multimokia
WIP, working on betterer system.
f69f606 
Still need to fix an issue in viewing + selecting new stories for normal type.
Booplicate
Booplicate previously approved these changes Nov 20, 2020
View reviewed changes
ThePotatoGuy
ThePotatoGuy previously approved these changes Dec 3, 2020
View reviewed changes
@multimokia multimokia dismissed stale reviews from ThePotatoGuy and Booplicate via 6fb9b11 December 3, 2020 19:32
Booplicate
Booplicate previously approved these changes Jan 11, 2021
View reviewed changes
ThePotatoGuy
ThePotatoGuy previously approved these changes Jan 17, 2021
View reviewed changes
@ThePotatoGuy ThePotatoGuy removed awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed labels Jan 17, 2021
@ThePotatoGuy ThePotatoGuy removed the awaiting testing code needs to be tested label Jan 17, 2021
@ThePotatoGuy
Copy link
Member

wait, @multimokia would this break in unstables, given the update script?

@multimokia
Copy link
Member Author

I don't think it will, mas_timePastSince() should handle it just fine. It'll simply be treated as it is in the current release once, then after the story, it would be set to a datetime. From what I'm seeing, we shouldn't have an issue in type comparisons otherwise.

@ThePotatoGuy ThePotatoGuy removed the DONT MERGE srs label Jan 17, 2021
@ThePotatoGuy ThePotatoGuy merged commit 4bc9ac9 into Monika-After-Story:content Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePotatoGuy ThePotatoGuy ThePotatoGuy approved these changes

@Legendkiller21 Legendkiller21 Legendkiller21 approved these changes

@Booplicate Booplicate Booplicate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

(Bug) No "I love you too!"
4 participants
@multimokia @ThePotatoGuy @Legendkiller21 @Booplicate