Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prop for submods with multiple authors + fixes #6331

Merged
merged 7 commits into from
Oct 11, 2020

Conversation

Booplicate
Copy link
Member

@Booplicate Booplicate commented Sep 14, 2020

Some submods have more than one person working on it. I saw a workaround, and I don't like it. This adds a new prop for Submod objects - coauthors. Assuming it's a list/tuple of strings. We show those on the submods screen near authors.

  • I also added __repr__ to the Submod class.
  • This also fixes compareVersionLists to work for any cases.
  • Added a new log (and a new method) for submods - submod_log.txt. For that I have to move some things in definitions (such as writelog) to init -995. This won't affect the places where we're already using those. It also makes sense to have logging stuff defined earlier.
  • We now have a new function wtf, which is an alias to writelog. Because why not I guess.

Testing:

  • verify that co-authors are shown on the screen, and the screen still looks good
  • verify nothing breaks if no co-authors were provided
  • verify that __repr__ for submods has all we need
  • verify that compareVersionLists works properly for any version lists
  • verify the new submod log works fine

@Booplicate Booplicate added awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Sep 14, 2020
@Booplicate Booplicate added this to the 0.11.6 milestone Sep 14, 2020
multimokia
multimokia previously approved these changes Sep 25, 2020
@Booplicate Booplicate changed the title New prop for submods with multiple authors New prop for submods with multiple authors + fixes Sep 25, 2020
Legendkiller21
Legendkiller21 previously approved these changes Sep 25, 2020
multimokia
multimokia previously approved these changes Oct 10, 2020
@multimokia multimokia removed awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested labels Oct 11, 2020
@multimokia multimokia merged commit 3b1ba5f into Monika-After-Story:content Oct 11, 2020
@Booplicate Booplicate deleted the submods_coauthors branch October 11, 2020 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants