-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New prop for submods with multiple authors + fixes #6331
Merged
multimokia
merged 7 commits into
Monika-After-Story:content
from
Booplicate:submods_coauthors
Oct 11, 2020
Merged
New prop for submods with multiple authors + fixes #6331
multimokia
merged 7 commits into
Monika-After-Story:content
from
Booplicate:submods_coauthors
Oct 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Booplicate
added
awaiting testing
code needs to be tested
awaiting code review
someone needs to check for syntax/logic/indentation errors
labels
Sep 14, 2020
Booplicate
force-pushed
the
submods_coauthors
branch
from
September 23, 2020 01:50
60643f1
to
4817ab6
Compare
also :boop: @multimokia
multimokia
requested changes
Sep 25, 2020
Co-authored-by: multimokia <[email protected]>
multimokia
previously approved these changes
Sep 25, 2020
Booplicate
changed the title
New prop for submods with multiple authors
New prop for submods with multiple authors + fixes
Sep 25, 2020
Legendkiller21
previously approved these changes
Sep 25, 2020
Booplicate
dismissed stale reviews from Legendkiller21 and multimokia
via
September 28, 2020 17:41
8385533
Booplicate
requested review from
ThePotatoGuy,
Legendkiller21 and
multimokia
September 28, 2020 17:53
multimokia
reviewed
Oct 5, 2020
Co-authored-by: multimokia <[email protected]>
multimokia
previously approved these changes
Oct 10, 2020
Co-authored-by: Legendkiller21 <[email protected]>
Legendkiller21
approved these changes
Oct 11, 2020
multimokia
approved these changes
Oct 11, 2020
multimokia
removed
awaiting code review
someone needs to check for syntax/logic/indentation errors
awaiting testing
code needs to be tested
labels
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some submods have more than one person working on it. I saw a workaround, and I don't like it. This adds a new prop for
Submod
objects -coauthors
. Assuming it's alist
/tuple
ofstring
s. We show those on thesubmods
screen near authors.__repr__
to theSubmod
class.compareVersionLists
to work for any cases.submod_log.txt
. For that I have to move some things indefinitions
(such aswritelog
) toinit -995
. This won't affect the places where we're already using those. It also makes sense to have logging stuff defined earlier.wtf
, which is an alias towritelog
. Because why not I guess.Testing:
__repr__
for submods has all we needcompareVersionLists
works properly for any version lists