Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better scrollable menus #5944

Merged
merged 11 commits into from
Jul 26, 2020
Merged

Better scrollable menus #5944

merged 11 commits into from
Jul 26, 2020

Conversation

Booplicate
Copy link
Member

This PR has some big changes to our screens.

  • Final items in scrollable menus are no more part of the screen viewpoint. That means you don't have to scroll the whole menu to close it. Thanks to @multimokia for the idea
  • The unseens menu now uses the mas_gen_scrollable_menu screen (the scrollable_menu screen is basically deprecated)
  • Derandoms and bookmarks now use mas_check_scrollable_menu
  • There's also some code/screens optimization (hopefully)

For testing

  • Verify we updated all mas_gen_scrollable_menu screens we use
  • Verify the booksmark/derand system still works (test on pool/rand topics and songs as well)
  • Verify twopane_scrollable_menu, mas_gen_scrollable_menu, and mas_check_scrollable_menu look good after the new changes. (especially pay attention to buttons placement)

@Booplicate Booplicate added awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested labels Jun 20, 2020
@Booplicate Booplicate added this to the 0.11.3 milestone Jun 20, 2020
@multimokia multimokia requested a review from jmwall24 June 20, 2020 16:36
@multimokia multimokia modified the milestones: 0.11.3, Maybe this rel Jun 20, 2020
@multimokia multimokia modified the milestones: Maybe this rel, 0.11.4 Jul 3, 2020
ThePotatoGuy
ThePotatoGuy requested changes Jul 12, 2020
View reviewed changes
Monika After Story/game/screens.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-topics.rpy Outdated Show resolved Hide resolved
Monika After Story/game/event-handler.rpy Outdated Show resolved Hide resolved
@Booplicate Booplicate requested a review from ThePotatoGuy July 13, 2020 22:29
@jmwall24 jmwall24 removed awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested labels Jul 26, 2020
@jmwall24 jmwall24 merged commit ceee21e into Monika-After-Story:content Jul 26, 2020
@Booplicate Booplicate deleted the better_scrollable_menus branch October 3, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Legendkiller21 Legendkiller21 Legendkiller21 approved these changes

@jmwall24 jmwall24 jmwall24 approved these changes

@multimokia multimokia multimokia approved these changes

@ThePotatoGuy ThePotatoGuy ThePotatoGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Booplicate @ThePotatoGuy @multimokia @jmwall24 @Legendkiller21