Update farewells to work similar to greetings #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multimokia
added
awaiting testing
ThePotatoGuy
requested changes
Jun 1, 2020
jmwall24
previously approved these changes
Jun 4, 2020
ThePotatoGuy
previously approved these changes
Jun 4, 2020
ThePotatoGuy
removed
the
awaiting code review
Legendkiller21
previously approved these changes
Jun 4, 2020
ThePotatoGuy
previously approved these changes
Jun 4, 2020
jmwall24
approved these changes
Jun 5, 2020
Legendkiller21
approved these changes
Jun 5, 2020
ThePotatoGuy
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Farewells used an outdated method for selection. This PR updates them to use a similar selection algorithm to greetings.
In addition to this, I have also created a new rule type,
MASProbabilityRule, which is a number between 1 and 10 (since this is designed to work with the function store.mas_utils.weightedChoice()An analogy for how the function works is as follows:
Priority number essentially corresponds to the amount of times the choice given is repeated in the list for a
random.choiceto pick from.So a probability rule with value 10 doesn't mean it's guaranteed to be selected, however it is more likely.
I have also rerandomed
bye_leaving_alreadyand added a conditional for it to show for sessions under 20 minutes in length.Testing: