Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a Go
net/proxy
Dialer
with theFromEnvironment
method and passes it in the Kafka client configuration underNet.Proxy
. This allows users to configure a proxy client from environment variables (for example usingALL_PROXY
). If no environment variable is set, the proxy will be transparent, making this PR backwards-compatible.For more safety, we could place this code under a condition on an extra configuration key (
use_proxy
, or specify explicitly the proxy configuration in the provider configuration). However, I've inspired this from the PostgreSQL provider's proxy supportI've tested this manually on one of our projects that uses this provider. Specifying a
ALL_PROXY=localhost:1080
environment variable makes the provider pas through the local proxy. Unsetting the variable makes it behave as before.Fixes #147