Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectorCreate() can return error when there is and it shouldn't proceed to connectorRead which returns no error #27

Merged
merged 1 commit into from
May 22, 2020
Merged

connectorCreate() can return error when there is and it shouldn't proceed to connectorRead which returns no error #27

merged 1 commit into from
May 22, 2020

Conversation

growingspaghetti
Copy link
Contributor

@growingspaghetti growingspaghetti commented May 22, 2020

connectorCreate() can return error when there's a error and it shouldn't proceed to connectorRead() which returns no error.

There was an error but it wasn't handling it.

This pull request adds the ability to provide actual errors like below instead of "Error: Provider produced inconsistent result after apply"

2020/05/22 17:49:09 [DEBUG] kafka-connect_connector.test: apply errored, but we're indicating that via the Error pointer rather than returning it: Create connector : {"error_code":500,"message":"Not a valid JDBC URL: http://localhost:5432"}

@growingspaghetti growingspaghetti changed the title connectorCreate() can return error when there's a error and it shouldn't proceed to connectorRead which returns no error connectorCreate() can return error when there is and it shouldn't proceed to connectorRead which returns no error May 22, 2020
@Mongey
Copy link
Owner

Mongey commented May 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants