Fixing HTTPS and exception on no results #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2020 17:28
…uick fix using the provided tvdb URL
…alid. Fixes exception on no results found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TvDb api changed to https only. Requests to http endpoints fail. Using https fixes that. Unfortunately, the mirrors.xml file still gives http links. A quick workaround is to use the provided base url and disregard any mirrors (which are not provided in the mirrors.xml file anyway).
There was a bug where if no results were found for a certain request, the parsed xml response evaluated as false and triggered an exeption despite being valid. A stricter false check corrects this.