Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important Semicolon #34

Merged
merged 7 commits into from
Sep 27, 2022
Merged

Important Semicolon #34

merged 7 commits into from
Sep 27, 2022

Conversation

mouse0270
Copy link
Contributor

  • Added semicolon to end of await game.settings.set(...) was causing reload logic to error

Removed attaching an onchange event to core setting. Instead places it in `then` promise.
switched to await.
Fixed function logic.
Added Comment to end of Line in hopes to make it easy to find to remove.
Added a super important semicolon that was missing
@mouse0270
Copy link
Contributor Author

Also don't ask me why github wants me to resubmit all the changes form yesterday too... I honestly couldn't figure out why it was doing that and just gave up.

@arcanistzed arcanistzed merged commit c63eff9 into Moerill:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants