Skip to content
This repository has been archived by the owner on May 14, 2019. It is now read-only.

Ugly ass description section #7

Closed
paulirish opened this issue Aug 26, 2014 · 5 comments
Closed

Ugly ass description section #7

paulirish opened this issue Aug 26, 2014 · 5 comments
Assignees
@paulirish

Comments

@paulirish
Copy link
Member

dis shit:

image
@paulirish
Copy link
Member Author

It's due to a pretty greedy regex that grabs text until the last */

unfortunately we have a bunch of /* jshint -W053 */ in our detects that get caught up in this.

solutions:

  • don't use flowerbox comments inside the code (not sure if jshint supports // for those)
  • write a goddamn better regex

@paulirish paulirish self-assigned this Aug 26, 2014
@SlexAxton
Copy link
Member

fwiw, it is commented: https://github.com/Modernizr/Modernizr/blob/f45491c2da1ac925d68b1a08b5922188423bde60/lib/generate-meta.js#L17

@patrickkettner
Copy link
Member

so like...\/\*\sDOC([\s\S]+?)\*\/?

(current for comparision)

@patrickkettner
Copy link
Member

also, fwiw, jshint does support //

paulirish added a commit to Modernizr/Modernizr that referenced this issue Aug 26, 2014
@paulirish
nongreedy regex for doc pulling.
f526d97 
See Modernizr/modernizr-ui#7
@paulirish
Copy link
Member Author

yaya thxxx

patrickkettner pushed a commit to patrickkettner/Modernizr that referenced this issue Feb 22, 2015
@paulirish
nongreedy regex for doc pulling.
cb147df 
See Modernizr/modernizr-ui#7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulirish paulirish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulirish @SlexAxton @patrickkettner