Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network、ethernet、securesocket の翻訳 #56

Conversation

stc1988
Copy link
Collaborator

@stc1988 stc1988 commented Dec 23, 2024

@meganetaaan さんレビューお願いします

@stc1988 stc1988 requested a review from meganetaaan December 23, 2024 14:26
Copy link
Collaborator

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます!
軽微な表現の指摘が数点あります 🙏

documentation/network/ethernet.md Outdated Show resolved Hide resolved
documentation/network/ethernet.md Outdated Show resolved Hide resolved
documentation/network/ethernet.md Outdated Show resolved Hide resolved
documentation/network/ethernet.md Show resolved Hide resolved
documentation/network/network.md Outdated Show resolved Hide resolved
documentation/network/network.md Outdated Show resolved Hide resolved
@meganetaaan
Copy link
Collaborator

TLSやWebSocket、MQTTなど、ネットワーク関連の様々なモジュールが公式にサポートされているのは大きなメリットですよね。日本のユーザにも伝わると良いなあ。

@stc1988
Copy link
Collaborator Author

stc1988 commented Jan 3, 2025

確認ありがとうございます。指摘修正しました。

基本的なIoT機器向けのネットワーク機能は揃っているので活用例をアピールしていきたいですね

Copy link
Collaborator

@meganetaaan meganetaaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます。LGTMです!

@meganetaaan meganetaaan merged commit ea951d4 into Moddable-OpenSource:dev/translate-jp Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants