Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme for translation effort #2

Closed
phoddie opened this issue Apr 14, 2024 · 5 comments
Closed

readme for translation effort #2

phoddie opened this issue Apr 14, 2024 · 5 comments

Comments

@phoddie
Copy link
Contributor

phoddie commented Apr 14, 2024

It is exciting to see this project get started!

I think it would be helpful to provide a document on this repository that introduces this translation project and how to get involved. Here is some information that would be helpful:

  • Goals
  • Basic approach
  • How to get involved
  • Contributing (PR & CLA)
  • Link to discord server for team discussion
  • Help needed (translating, reviewing, etc)

It could begin as a short document that grows in time as needed.

@meganetaaan
Copy link
Collaborator

Thank you for your suggestion. I agree that providing a document introducing the project's key points would be very helpful. I will work on creating this and adding it to the top of the repository. Using a separate markdown file linked from the moddable-jp/readme.md would be a good approach.

@meganetaaan
Copy link
Collaborator

I have created a PR at #5

Could you please add "reviewer" permission for @stc1988?

I may also request additional permissions for other volunteer developers later on.

@phoddie
Copy link
Contributor Author

phoddie commented Apr 16, 2024

I have created a PR at #5

Looks great. ;)

Could you please add "reviewer" permission for @stc1988?

I added @stc1988 in the "triage" role. I think this is what is needed? It is easy to change, if necessary.

I may also request additional permissions for other volunteer developers later on.

No problem.

@meganetaaan
Copy link
Collaborator

meganetaaan commented Apr 21, 2024

#5 merged!
I've also created a new issue to share and manage the translation progress.

I added @stc1988 in the "triage" role. I think this is what is needed? It is easy to change, if necessary.

This works perfectly. I can now make a review request to stc1988. Thank you for setting that up!

@mshioji has also volunteered to be a reviewer. Could you please assign them the same role as well?

@phoddie
Copy link
Contributor Author

phoddie commented Apr 21, 2024

Glad that worked for @stc1988. I've added @mshioji in the Triage role, as requested.

I've also created #3 share and manage the translation progress.

That's a long list. Good luck. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants