Enforce default discriminant type for all representations and across editions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we could do this for all cases right? even the non |
|
I was having the same thought, but I would have said that would break all proc-macros out there, so we should be safe? I don't want to further ruin the code generation ... WDYT? |
|
We could also ask on Zulip again? |
|
well, I'd say even the change to |
daxpedda
commented
Sep 3, 2023
daxpedda
force-pushed
the
const-validation
branch
from
4d72392 to
22fdeff
Compare
daxpedda
changed the title
|
It's done, checking both now. |
daxpedda
force-pushed
the
const-validation
branch
from
22fdeff to
817d52f
Compare
|
I think we can get this out first and figure out #83 later when we get an answer. |
ModProg
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Zulip.
Yanking time ... cry me a river ...