Add displayGameName() and lootGameName() to plugin-base
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Modifications - Add `lootGameName()` which gives the plugin a tad bit more control over LOOT cli args - Add `displayGameName()` which will be used separate display-specific calls & more integral calls to `gameName()`, will also pave way for deeper plugin localization
Holt59
approved these changes
May 18, 2024
Twinki14
added a commit
to Twinki14/modorganizer
that referenced
this pull request
May 20, 2024
# Motivations - ModOrganizer2/modorganizer-game_ttw#36 (comment) Surfaced desires to change the Fallout TTW plugin's gameName to something more obvious, from TTW to Tale of Two Wastelands, but that would cause existing profiles to break, `displayGameName()` added in ModOrganizer2/modorganizer-uibase#141 gives us the option to change the way the game plugin is displayed, but leaves the existing integral `gameName()` alone - Similarly ModOrganizer2/modorganizer-game_ttw#36 attempted to fix the sort button LOOT cli argument by changing the `gameShortName()`, as 'TTW' isn't a valid option for LOOT, but that comes with some pretty concerning possible issues # Modifications - Use `displayGameName()` in create instance dialogs & the main window, this doesn't cover all places `gameName()` was being used for purely display reasons, but it covers the bulk - Use `lootGameName()` instead of `gameShortName()` for LOOT cli initiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
lootGameName()which will give the plugin a tad bit more control over LOOT cli argsdisplayGameName()which will be used to separate display-specific calls & more integral calls togameName(), will also pave way for deeper plugin localizationNotes
Changes are planned to other pieces of MO in different repositories that will use these additions