Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jump Feeds #190

Merged
merged 5 commits into from
Nov 29, 2019
Merged

Update Jump Feeds #190

merged 5 commits into from
Nov 29, 2019

Conversation

davevsdave
Copy link
Contributor

No description provided.

@davevsdave
Update Jump Feeds
a8ac347 
Update feed url scheme for: Austin, Denver, Los Angeles, New York City, Denver, Sacramento, San Diego, Santa Cruz, Seattle, and San Francisco.
New Feed Added: Tampa
@davevsdave
Fix typo: "CA" to "FL" for Tampa Jump Feed
49068a9
jcn
jcn suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@jcn jcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Can you update the System Names to match what's listed in the feeds themselves (which will also help differentiate between the scooter and bike feeds). Thanks.

@davevsdave
Update system names based on system_information.json
6596dae 
A bit less clean organizationally in the list using this name format, but accurate to the feed names.  Additionally, removed Providence feed as they have terminated that program and Chicago's system feeds are returning 404 so I simply used the same naming format from other feeds.
@davevsdave
Copy link
Contributor Author

These changes should be addressed. Let me know if you need something additional.

jcn
jcn suggested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jcn jcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. One last comment - looks like the Chicago Bike JUMP url is 404ing for all internal pages. Is there a better URL for that one?

systems.csv Outdated Show resolved Hide resolved
@jcn jcn merged commit 6e409d8 into MobilityData:master Nov 29, 2019
@jcn jcn mentioned this pull request Nov 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bddq bddq bddq approved these changes

@jcn jcn jcn approved these changes

Assignees
No one assigned
Labels
systems.csv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davevsdave @jcn @bddq @josee-sabourin