Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add generateBuilders #121

Closed
wants to merge 2 commits into from
Closed

chore: add generateBuilders #121

wants to merge 2 commits into from

Conversation

dersvenhesse
Copy link
Contributor

This PR adds the option generateBuilders to jsonschema2pojo since those make the usage of the generated models much more fun. Additionally, a link in the documentation is fixed.

Copy link
Collaborator

@testower testower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dersvenhesse
Copy link
Contributor Author

dersvenhesse commented May 23, 2024

For consistency I would suggest adding builders to these classes as well: https://github.com/MobilityData/gbfs-json-schema/tree/master/models/java/gbfs-java-model/src/main/java/org/mobilitydata/gbfs/v2_3/gbfs (same with v2_2)

I agree, hence I already added generateBuilders three times in pom.yml.

@testower
Copy link
Collaborator

I agree, hence I already added generateBuilders three times in pom.yml.

The classes I pointed to are not generated, so you need to add them manually. The generated sources are not checked in to the repo.

@dersvenhesse
Copy link
Contributor Author

I'm closing this PR. I was confused with exactly these not generated classes without a builder, the other ones already provide builders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants