Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.0-RC2 schemas #100

Merged
merged 37 commits into from
Nov 15, 2023
Merged

Add 3.0-RC2 schemas #100

merged 37 commits into from
Nov 15, 2023

Conversation

tdelmas
Copy link
Collaborator

@tdelmas tdelmas commented Nov 13, 2023 •
edited by richfab
Loading

Include RC2 changes (listed in the commits names)

v3.0-RC2 release note: https://github.com/MobilityData/gbfs/releases/tag/v3.0-RC2

@tdelmas tdelmas marked this pull request as ready for review November 13, 2023 13:02
@richfab
Copy link
Contributor

richfab commented Nov 13, 2023

Thank you @tdelmas for this very helpful contribution! ⚡

I would recommend to include MobilityData/gbfs#559 in this PR once the vote has passed (the vote closes in a few hours).

richfab
richfab requested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution @tdelmas! Thank you very much!

I added a few change requests.

Also, could you please add "3.0-RC2" to the file v3.0-RC/gbfs_versions.json like for the other schemas? Thank you!

v3.0-RC2/vehicle_types.json Outdated Show resolved Hide resolved
v3.0-RC2/gbfs.json Outdated Show resolved Hide resolved
v3.0-RC2/geofencing_zones.json Outdated Show resolved Hide resolved
v3.0-RC2/geofencing_zones.json Outdated Show resolved Hide resolved
v3.0-RC2/station_status.json Outdated Show resolved Hide resolved
v3.0-RC2/system_alerts.json Outdated Show resolved Hide resolved
v3.0-RC2/geofencing_zones.json Outdated Show resolved Hide resolved
v3.0-RC2/station_information.json Outdated Show resolved Hide resolved
v3.0-RC2/station_information.json Outdated Show resolved Hide resolved
v3.0-RC2/station_information.json Outdated Show resolved Hide resolved
tdelmas and others added 4 commits November 14, 2023 21:55
@tdelmas @richfab
eco_labels
79817dd 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
0cd1046 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
9b4c3f4 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
142c87d 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
tdelmas and others added 4 commits November 14, 2023 21:56
@tdelmas @richfab
RFC3339 format
0dc685a 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
7248bae 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
vehicle_type_id
544bd6f 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
vehicle_type_ids
fe5d2de 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
tdelmas and others added 3 commits November 14, 2023 21:58
@tdelmas @richfab
vehicle_type_ids
d3d621f 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
vehicle_type_ids
e2671f9 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
description
fe8e201 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
tdelmas and others added 3 commits November 14, 2023 21:59
@tdelmas @richfab
description
7cc2f07 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
description
cea869f 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
2ebf465 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
description
8689e9a 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
richfab
richfab reviewed Nov 14, 2023
View reviewed changes
v3.0-RC/gbfs_versions.json Outdated Show resolved Hide resolved
@tdelmas
Copy link
Collaborator Author

tdelmas commented Nov 15, 2023 •
edited
Loading

@richfab thank you for that very detailed review! Everything should be fixed now

@tdelmas tdelmas requested a review from richfab November 15, 2023 08:35
richfab
richfab requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tdelmas! Thank you very much for the fast changes ⚡ We can almost merge 🙌

  • The Timestamp needs to be changed to RFC3339 format in a few more descriptions.
  • vehicle_type_ids needs to be changed to plural in one more place.

Thanks to you the JSON Schema are up to date very quickly, so thank you! 🙏

v3.0-RC2/gbfs_versions.json Outdated Show resolved Hide resolved
v3.0-RC2/geofencing_zones.json Outdated Show resolved Hide resolved
v3.0-RC2/manifest.json Outdated Show resolved Hide resolved
v3.0-RC2/station_information.json Outdated Show resolved Hide resolved
v3.0-RC2/station_status.json Outdated Show resolved Hide resolved
v3.0-RC2/system_pricing_plans.json Outdated Show resolved Hide resolved
v3.0-RC2/system_regions.json Outdated Show resolved Hide resolved
v3.0-RC2/vehicle_status.json Outdated Show resolved Hide resolved
v3.0-RC2/vehicle_types.json Outdated Show resolved Hide resolved
v3.0-RC2/station_information.json Outdated Show resolved Hide resolved
tdelmas and others added 12 commits November 15, 2023 16:52
@tdelmas @richfab
RFC3339 format
75fe05a 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
fc32448 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
987fe7c 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
b01bf32 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
ba66dd4 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
b25ef71 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
43cf86a 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
f39fd6f 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
0d31c88 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
e546a05 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
RFC3339 format
38eb546 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas @richfab
vehicle_type_ids
393081b 
Co-authored-by: Fabien Richard-Allouard <[email protected]>
@tdelmas tdelmas requested a review from richfab November 15, 2023 15:54
richfab
richfab approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏
Merging now 🚀
Thank you!

@richfab richfab merged commit 5d44652 into MobilityData:master Nov 15, 2023
testower added a commit to entur/gbfs-json-schema that referenced this pull request Nov 20, 2023
@testower
Merge pull request #10 from entur/master
80f902c 
Add 3.0-RC2 schemas (MobilityData#100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richfab richfab richfab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdelmas @richfab