Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per-xcodeproj Bazel configurations #1062

Merged

Conversation

brentleyjones
Copy link
Contributor

Fixes #641.

@jpsim
Copy link
Contributor

jpsim commented Sep 9, 2022

The way this works is a bit surprising to me.

For example I expected that if I have this config:

build:my_config --define=abcd=1

and I set config = "my_config", in my xcodeproj invocation that the --define would be picked up when building in Xcode, but in fact I have to set this in my config:

build:my_config_build --define=abcd=1

Previously if I set something on the rules_xcodeproj config in bazelrc, it would propagate to all rules_xcodeproj specialized configs (build, info, etc.).

Should this follow the same principle?

@brentleyjones
Copy link
Contributor Author

Just build:my_config --define=abcd=1 should work, as build:my_config_build --config=my_config should be in the xcodeproj_extra_flags.bazelrc. I'll see why that's not the case.

doc/rules-xcodeproj.md Outdated Show resolved Hide resolved
@brentleyjones brentleyjones enabled auto-merge (squash) September 9, 2022 15:59
@brentleyjones brentleyjones merged commit 64da191 into main Sep 9, 2022
@brentleyjones brentleyjones deleted the bj/add-support-for-per-xcodeproj-bazel-configurations branch September 9, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow per-xcodeproj Bazel configuration
3 participants