Pass simDevice to the shutdown method #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanwng
force-pushed
the
nanwng/fix-bluepill-tests
branch
from
0b75ba6 to
b507f60
Compare
Signed-off-by: Nan Wang <[email protected]>
nanwng
force-pushed
the
nanwng/fix-bluepill-tests
branch
from
e20a9eb to
10d406b
Compare
chenxiao0228
approved these changes
Aug 30, 2023
nanwng
added a commit
that referenced
this pull request
Aug 30, 2023
Signed-off-by: Nan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bluepill test was hanging and causing timeout during GHA.
Investigated and figured out the issue being one of the
shutdownSimulatorWithError:call should pass in asimDeviceexplicitly.Let's see if the tests are going to pass