Better fix for app hanging by printing a bunch of new lines #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so hangs." This reverts commit b9feff9.
We've seen from logs that sometimes the "Infinite Loop" condition is hit. The current theory is that it's either an invalid UTF-8 string or we're splitting a UTF-8 string in the middle. This fix would both illuminate what's going on and prevent the issue in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more careful examination illustrated that the problem wasn't with a test that loops indefinitely. It turns out that we weren't error checking the UTF-8 decoding of the buffer and if the data happened to be cut in the middle of a UTF-8 char, you'd get an error decoding it and the loop would never finish.
This isn't the Right Fix(tm), but it's better than what's in there... the right fix would be to read the data in chunks without interpreting anything until we get to the
\n, then convert the full line to an NSstring and move the remaining data to another buffer.We're pushing this out though because it's a quick workaround for a serious bug.