Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower JVM target to Java 11 #648

Merged
merged 1 commit into from
Jul 7, 2024
Merged

fix: lower JVM target to Java 11 #648

merged 1 commit into from
Jul 7, 2024

Conversation

msfjarvis
Copy link
Contributor

Related to #640

Description

Lowers JVM target to 11 as a workaround for Kotlin/dokka#2956

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Plan

Disabled signing and did a local publish with gradle publishToMavenLocal which successfully generated documentation.

Checklist:

Before submitting your PR, please review and check all of the following:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective
  • New and existing unit tests pass locally with my changes

Additional Notes:

Add any other information about the PR here.

Signed-off-by: Harsh Shandilya <[email protected]>
@msfjarvis msfjarvis mentioned this pull request Jul 7, 2024
@matt-ramotar
Copy link
Collaborator

Thanks @msfjarvis 👍🏽 - I think we'll want to make these updates too #649

@digitalbuddha digitalbuddha merged commit 48266f4 into MobileNativeFoundation:main Jul 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants