Avoid duplicated reading RPN code execution across multiple clients #27

cpuwolf · 2024-03-15T20:23:25Z

While multiple clients Add(MF.SimVars.Add.xxxxRPNcodexxx) the exact same SimVars to WASM,
From MSFS2020 perspective, it is unnecessary to execute the same RPNcode several times in each frame. This is an enhancement change to reduce FPS impact
WASM will smartly execute duplicated SimVars only once in each frame.

introduce new data structure:

//RPN code execution for reading values in every frame
struct ReadRPNCode {
	std::string Code;
	int RetType; //RetType: 0:float 1:integer 2:string
	std::vector<SimVar> SimVars;
	std::vector<StringSimVar> StringSimVars;
};

only release build works with MSFS2020

best performance for RPN execution

found below log shows NAV1 actually is no changing at all MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4 MobiFlight[Client_328838310]: SimVar (A:NAV ACTIVE FREQUENCY:1,MHz) with ID 21056 has value 108.4

DocMoebiuz · 2024-03-16T00:53:47Z

i am currently at FSWeekend, i will be looking at this PR next week

cpuwolf · 2024-05-05T21:54:29Z

@DocMoebiuz Could you take a look?

DocMoebiuz · 2024-05-05T21:56:32Z

Not yet tbh :(

DocMoebiuz · 2024-05-05T21:56:51Z

Does this work with strings too? yeah, looks like you are also treating strings.

How much of an impact is this? What did you see in FPS drop?

cpuwolf · 2024-05-05T23:06:26Z

std::vector SimVars;
std::vector StringSimVars;

so string is considered in this change. I don't have direct evidence to see FPS drop, but this change will improve FPS when we have multiple clients

@DocMoebiuz think about you have multiple clients, but they have exact same simvars (L:N_FCU_HEADING), then WASM will execute "(L:N_FCU_HEADING)" multiple times in MSFS one frame update, it is totally waste of FPS

DocMoebiuz

Sorry for the tardy review.

src/Sources/Code/Module.cpp

DocMoebiuz · 2024-09-04T21:11:14Z

src/Sources/Code/Module.cpp

 // data struct for dynamically registered SimVars
 struct SimVar {
 	int ID;
 	int Offset;
-	std::string Name;


Why remove? This was valuable in all the different log messages for troubleshooting. Was it not?

I have a dedicated commit "relocate struct SimVar->Name to ReadRPNCode->Code"

the purpose of this pull is to avoid duplicated RPN code, the "Name" here actually is is RPN code, so we need to remove redundant "Name"

But it is missing now in the log statements which is unfortunate.

src/Sources/Code/Module.cpp

DocMoebiuz · 2024-09-04T21:12:39Z

src/Sources/Code/Module.cpp


 #if _DEBUG
-	std::cout << "MobiFlight[" << client->Name.c_str() << "]: SimVar " << simVar.Name.c_str();
-	std::cout << " with ID " << simVar.ID << " has value " << simVar.Value << std::endl;
+		std::cout << "MobiFlight[" << simVar.clint->Name.c_str() << "]: SimVar " << rpn.Code.c_str();


Suggested change

std::cout << "MobiFlight[" << simVar.clint->Name.c_str() << "]: SimVar " << rpn.Code.c_str();

std::cout << "MobiFlight[" << simVar.client->Name.c_str() << "]: SimVar " << rpn.Code.c_str();

DocMoebiuz · 2024-09-04T21:12:51Z

src/Sources/Code/Module.cpp

+		if (simVar.Value == stringVal) continue;
+		simVar.Value = stringVal;
+
+		WriteSimVar(simVar, simVar.clint);


Suggested change

WriteSimVar(simVar, simVar.clint);

WriteSimVar(simVar, simVar.client);

DocMoebiuz · 2024-09-04T21:13:00Z

src/Sources/Code/Module.cpp


 #if _DEBUG
-	std::cout << "MobiFlight[" << client->Name.c_str() << "]: StringSimVar " << simVar.Name.c_str();
-	std::cout << " with ID " << simVar.ID << " has value " << simVar.Value << std::endl;
+		std::cout << "MobiFlight[" << simVar.clint->Name.c_str() << "]: StringSimVar " << rpn.Code.c_str();


Suggested change

std::cout << "MobiFlight[" << simVar.clint->Name.c_str() << "]: StringSimVar " << rpn.Code.c_str();

std::cout << "MobiFlight[" << simVar.client->Name.c_str() << "]: StringSimVar " << rpn.Code.c_str();

DocMoebiuz · 2024-09-07T19:20:11Z

@cpuwolf you marked some of the comments as resolved but you might not have pushed your changes yet.

cpuwolf · 2024-09-07T23:48:11Z

@cpuwolf you marked some of the comments as resolved but you might not have pushed your changes yet.

should I resubmit the pull? I am expecting Github can do online review and revise the code realtime

DocMoebiuz · 2024-09-08T04:44:13Z

You have to make the changes in your branch and simply push the branch again. The PR will automatically update then. But simply resolving the conversation doesn't do it.

cpuwolf · 2024-10-23T02:47:21Z

@DocMoebiuz I have uploaded revised version

cpuwolf added 4 commits March 14, 2024 17:04

Avoid duplicated SimVars, introduce ReadRPNCode

3916c3d

only release build works with MSFS2020

relocate struct SimVar->Name to ReadRPNCode->Code

4514494

best performance for RPN execution

add duplicated StringSimVar handling as well

7c9fbed

rename RollingClientDataReadIndex

ec92731

cpuwolf changed the title ~~Avoid duplicated RPN code execuation across multiple clients~~ Avoid duplicated reading RPN code execuation across multiple clients Mar 15, 2024

cpuwolf added 2 commits March 16, 2024 06:51

ClearSimVars() clears RNP code list as well

0e3ffdb

cpuwolf force-pushed the 1.0.1-client.dup.simvar branch from ac04712 to 152c509 Compare March 15, 2024 22:55

cpuwolf changed the title ~~Avoid duplicated reading RPN code execuation across multiple clients~~ Avoid duplicated reading RPN code execution across multiple clients Mar 26, 2024

DocMoebiuz requested changes Sep 4, 2024

View reviewed changes

change clint to client

7935ed4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid duplicated reading RPN code execution across multiple clients #27

Avoid duplicated reading RPN code execution across multiple clients #27

cpuwolf commented Mar 15, 2024 •

edited

Loading

DocMoebiuz commented Mar 16, 2024

cpuwolf commented May 5, 2024

DocMoebiuz commented May 5, 2024

DocMoebiuz commented May 5, 2024 •

edited

Loading

cpuwolf commented May 5, 2024 •

edited

Loading

DocMoebiuz left a comment

DocMoebiuz Sep 4, 2024

cpuwolf Sep 5, 2024 •

edited

Loading

DocMoebiuz Sep 7, 2024

DocMoebiuz Sep 4, 2024

DocMoebiuz Sep 4, 2024

DocMoebiuz Sep 4, 2024

DocMoebiuz commented Sep 7, 2024

cpuwolf commented Sep 7, 2024

DocMoebiuz commented Sep 8, 2024

cpuwolf commented Oct 23, 2024

	std::cout << "MobiFlight[" << simVar.clint->Name.c_str() << "]: SimVar " << rpn.Code.c_str();
	std::cout << "MobiFlight[" << simVar.client->Name.c_str() << "]: SimVar " << rpn.Code.c_str();

	WriteSimVar(simVar, simVar.clint);
	WriteSimVar(simVar, simVar.client);

Avoid duplicated reading RPN code execution across multiple clients #27

Are you sure you want to change the base?

Avoid duplicated reading RPN code execution across multiple clients #27

Conversation

cpuwolf commented Mar 15, 2024 • edited Loading

DocMoebiuz commented Mar 16, 2024

cpuwolf commented May 5, 2024

DocMoebiuz commented May 5, 2024

DocMoebiuz commented May 5, 2024 • edited Loading

cpuwolf commented May 5, 2024 • edited Loading

DocMoebiuz left a comment

Choose a reason for hiding this comment

DocMoebiuz Sep 4, 2024

Choose a reason for hiding this comment

cpuwolf Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

DocMoebiuz Sep 7, 2024

Choose a reason for hiding this comment

DocMoebiuz Sep 4, 2024

Choose a reason for hiding this comment

DocMoebiuz Sep 4, 2024

Choose a reason for hiding this comment

DocMoebiuz Sep 4, 2024

Choose a reason for hiding this comment

DocMoebiuz commented Sep 7, 2024

cpuwolf commented Sep 7, 2024

DocMoebiuz commented Sep 8, 2024

cpuwolf commented Oct 23, 2024

cpuwolf commented Mar 15, 2024 •

edited

Loading

DocMoebiuz commented May 5, 2024 •

edited

Loading

cpuwolf commented May 5, 2024 •

edited

Loading

cpuwolf Sep 5, 2024 •

edited

Loading