-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed static classes #489
base: development
Are you sure you want to change the base?
Conversation
Does git have a hook for running tests on commit/push/pr? I have also thought about adding tests for things, but after working in the real world, no one manually runs tests - there are systems in place to do that for you before submitting/while review iterating/etc. Otherwise I foresee those tests going ignored soon after being introduced |
Github doesn't as far as I know. We could link a the repo to a tfs online server and build it and run the tests there, but it's not free :/ I will resolve the conflicts tonight. |
Awesome, you took quite off some work from me:) |
About running tests on commit/push/pr you should add some hooks, maybe to run a install.sh which generates some hooks under |
not sure but after reading up on static and checking the file, this might also solve #434 :) |
https://www.appveyor.com/ could do automatic build checks and testing. |
I've used myget previously. It was prety good. |
There are now cyclical dependencies again -.- I don't get usable pokestops close to me, can somebody please check? |
Your PR has conflicts, please solve. |
Removed conflicts. Can't really test it at the moment... |
guess that has nothing to do with the branch ;) |
Removed static classes and injecting the classes with constructor injection.
Next steps could be: