Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce new compareItinerary method for excluding attributes #50

Merged
merged 2 commits into from
Feb 15, 2025
Merged

feat: introduce new compareItinerary method for excluding attributes #50

merged 2 commits into from
Feb 15, 2025

Conversation

Kvnstrck
Copy link

@Kvnstrck Kvnstrck commented Feb 14, 2025 •
edited
Loading

Closes #49

Checklist

Formalities:

  • PR targets staging, if compare branch is chore/* or feat/*
  • PR title is formatted as a commit
  • New functions are commented in the source file
  • Notes are added to wiki

Quality assurance:

  • Manual build and unit/component testing:
    • Linux
    • macOS
    • Windows
  • Manual End-To-End testing:
    • Upload of query batch
    • Computation of routing results
    • Download plan
    • Upload plan
    • Compare functionality

For staging -> master

  • Check for relevant open issues
  • After merge: Create release

@Kvnstrck Kvnstrck added enhancement New feature or request Data Processing Data Processing Team labels Feb 14, 2025
@Kvnstrck Kvnstrck added this to the Iteration 5 milestone Feb 14, 2025
@Kvnstrck Kvnstrck self-assigned this Feb 14, 2025
@nicosvv nicosvv linked an issue Feb 14, 2025 that may be closed by this pull request
feat: deep-equals #49
Closed
@Kvnstrck Kvnstrck merged commit fc4ba23 into staging Feb 15, 2025
1 of 2 checks passed
@Kvnstrck Kvnstrck deleted the feat/deep-equals branch February 15, 2025 12:00
D3vZro pushed a commit that referenced this pull request Feb 17, 2025
@Kvnstrck @D3vZro
feat: introduce new compareItinerary method for excluding attributes (#…
c74e20c 
…50)

* feat: introduce new compareItinerary method for excluding attributes

* chore: add comments and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoPhliFra MoPhliFra MoPhliFra approved these changes

@D3vZro D3vZro D3vZro approved these changes

@Kha1r0 Kha1r0 Kha1r0 approved these changes

@nicosvv nicosvv nicosvv approved these changes

Assignees

@Kvnstrck Kvnstrck

Labels
Data Processing Data Processing Team enhancement New feature or request
Projects
None yet
Milestone
Iteration 5
Development

Successfully merging this pull request may close these issues.

feat: deep-equals
5 participants
@Kvnstrck @MoPhliFra @D3vZro @Kha1r0 @nicosvv