Fix the fallback controllers being backwards #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keveleigh
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
10 tasks
AMollis
approved these changes
Feb 8, 2024
|
@shaynie I think this means you need to branch and cherry pick this change. Or we restart the release |
shaynie
pushed a commit
that referenced
this pull request
Feb 8, 2024
Whoops the fallback controllers were backwards (cherry picked from commit c4352bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#559 introduced a regression where the controller models' rotational offset wasn't properly committed to the PR. This PR fixes that.