-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SimpleButton + demo scene #635
Adding SimpleButton + demo scene #635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please share some screen shots of the new scenes?
org.mixedrealitytoolkit.uxcomponents/Editor/CreateElementMenus.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.uxcomponents/Editor/CreateElementMenus.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you added a new feature please make sure the minor versions of 'uxcomponents' and 'standardassets' have been updated since the last release (https://github.com/orgs/MixedRealityToolkit/discussions/640).
It looks like 'standardassets' version needs to be updated from 3.0.2 to 3.1.0; edit 'standassets' package.json and CHANGELOG.md.
It looks like `uxcomponents' version is good (min version already update), but you need to update the dependency version in 'uxcompoents' to the latest 'standardassets' version:
Also the fonts in the screenshot looks off. Can you make sure it's using the same font and size as the "Action Button"
org.mixedrealitytoolkit.uxcomponents/Editor/CreateElementMenus.cs
Outdated
Show resolved
Hide resolved
org.mixedrealitytoolkit.uxcomponents/Button/Prefabs/SimpleButton.prefab
Outdated
Show resolved
Hide resolved
… all SimpleButton fonts the same size as ActionButton
Done in latest commit. |
…ming demo scene, adding new Editor's MenuItem option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an "MRTK Issue" to add "StateVisualizer" to the new "Simplified Button"
The SimpleButton structure is inspired in Mesh's MasterButtonRoot which is a simplified version of MRTK3's Action Button. Note: Materials (including shaders) are those existing in MRTK3 or its associated packages.