Fix minor issue of cubes changing color in some scenes when grabbed #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whebertML
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
AMollis
requested changes
Nov 8, 2023
There was a problem hiding this comment.
@whebertML can you please add screen shots of the before and after changes
Also, please add more details to the PR description. In particular I'm curious about the need for this change.
AMollis
added
the
Package: Extended Assets
AMollis
reviewed
Nov 8, 2023
org.mixedrealitytoolkit.extendedassets/Materials/ObjectManipulationGrabbedLime.mat
Show resolved
Hide resolved
|
Before and after screen shots placed in issue description #544 |
AMollis
approved these changes
Nov 9, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #544
Fixes a minor cosmetic / quality issue with some of the MRTKDevTemplate samples where some of the colored cubes change color once grabbed and released. The intended behavior would be for the cubes to retain their color to maintain the uniqueness of each cube during and after manipulation, even after falling off the edge and being restored.
Just a minor issue with a simple material reference fix.