Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deservicify core #2458

Merged
merged 7 commits into from
Jul 7, 2019
Merged

Deservicify core #2458

merged 7 commits into from
Jul 7, 2019

Commits on Jul 7, 2019

  1. De-servicify router (mostly) 

    Still uses the redraw service, but it no longer has an intermediate
service of its own.

Also, did a *lot* of test deduplication in this. About 30-40% of the
router service tests were already tested on the main router API instance
itself.

Bundle size decreased from 9560 to 9548 bytes min+gzip.
    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    7ab7ff5 View commit details
    Browse the repository at this point in the history

  2. Merge m.mount + m.redraw, update router 

    Simplifies the router and redraw mechanism, and makes it much easier to
keep predictable.

Bundle size down to 9433 bytes min+gzip, docs updated accordingly.
    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    c191910 View commit details
    Browse the repository at this point in the history

  3. Make mithril/render just return the m.render function directly.

    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    91d39f6 View commit details
    Browse the repository at this point in the history

  4. Deservicify m.render, revise m.route 

    - You now have to use `mithril/render/render` directly if you want an
  implicit redraw function. (This will likely be going away in v3.)
- Revise `m.route` to only `key` components
    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    0eee76e View commit details
    Browse the repository at this point in the history

  5. Add redraw to m.render, deservicify requests

    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    35a34eb View commit details
    Browse the repository at this point in the history

  6. Test error logging

    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    b9ba19e View commit details
    Browse the repository at this point in the history

  7. Update docs + changelog [skip ci]

    @dead-claudia
    dead-claudia committed Jul 7, 2019
    Configuration menu
    Copy the full SHA
    221328d View commit details
    Browse the repository at this point in the history