Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select option to use empty string value, add tests. #1828

Merged
merged 2 commits into from
May 1, 2017
Merged

Fix select option to use empty string value, add tests. #1828

merged 2 commits into from
May 1, 2017

Conversation

spacejack
Copy link
Contributor

This is an attempt to fix: #1814

Adds related tests.

@spacejack
Copy link
Contributor Author

Would be great if someone can check that I'm understanding the old parameter in setAttr correctly.

dead-claudia
dead-claudia approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And yes, you understood the old parameter correctly (the old attr value).

@dead-claudia dead-claudia merged commit 8191f78 into MithrilJS:next May 1, 2017
@pygy pygy mentioned this pull request May 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot assign empty string value to select option
2 participants
@spacejack @dead-claudia