Fix tile entities double-rendering and sometimes crashing clients when broken #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mithion
pushed a commit
that referenced
this pull request
Sep 17, 2015
Fix tile entities double-rendering and sometimes crashing clients when broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After digging through to try and fix #1243, I eventually found that tile entities were being rendered twice, once as the block and once as the tile entity.
This worked just fine until a tile entity called a different renderer (e.g. the calcinator calling the item renderer to display the smelting item) and the block was being broken at the same time. The tile entity render would occur just fine, but the block render would cause the client to crash as the client tried to tessellate both the non-tile renderer and the block renderer at the same time.
This pull request fixes #1243 and similar issues by removing the extra block render.